Re: Restore support for USE_ASSERT_CHECKING in extensions only

On Sat, 11 Jan 2025 at 12:48, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > On Sat, 11 Jan 2025 at 12:32, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> No, this completely fails to address the problem. The concern is
> >> that the extension has been compiled under USE_ASSERT_CHECKING,
> >> so it will try to call the function. If the function's not there
> >> in core, kaboom.
>
> > hmm, you got me confused. Maybe you missed that the extension will be
> > the one compiling the static inline TupleDescCompactAttr() function
> > and will use the macro instead?
>
> No, I don't think I missed anything. Inline function or no, the
> extension will contain a call to verify_compact_attribute(),
> and that won't work if the core backend doesn't have that function.

I think I'd only thought in terms of getting the extension to build
and failed to consider that the already built extension might be
created in builds with and without USE_ASSERT_CHECKING.

David