Re: Restore support for USE_ASSERT_CHECKING in extensions only

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Andrew Kane <andrew(at)ankane(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Restore support for USE_ASSERT_CHECKING in extensions only
Date: 2025-01-10 23:48:08
Message-ID: 2715919.1736552888@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Sat, 11 Jan 2025 at 12:32, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> No, this completely fails to address the problem. The concern is
>> that the extension has been compiled under USE_ASSERT_CHECKING,
>> so it will try to call the function. If the function's not there
>> in core, kaboom.

> hmm, you got me confused. Maybe you missed that the extension will be
> the one compiling the static inline TupleDescCompactAttr() function
> and will use the macro instead?

No, I don't think I missed anything. Inline function or no, the
extension will contain a call to verify_compact_attribute(),
and that won't work if the core backend doesn't have that function.

Depending on what platform you test on, the extension might have
to actually reach that function call before it fails.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Kane 2025-01-10 23:55:53 Re: Restore support for USE_ASSERT_CHECKING in extensions only
Previous Message David Rowley 2025-01-10 23:40:46 Re: Restore support for USE_ASSERT_CHECKING in extensions only