Re: Restore support for USE_ASSERT_CHECKING in extensions only

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Kane <andrew(at)ankane(dot)org>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Restore support for USE_ASSERT_CHECKING in extensions only
Date: 2025-01-11 00:15:09
Message-ID: 2718966.1736554509@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Kane <andrew(at)ankane(dot)org> writes:
> I've updated the patch to make verify_compact_attribute a no-op.
> The extension sets USE_ASSERT_CHECKING, which is why the macro approach
> doesn't work (it won't take that path).

LGTM

> Also, it looks like it fails when creating the extension / loading the
> shared library (on Ubuntu), not when linking (as I misstated earlier).

I think that on macOS and perhaps a couple of other platforms, there'd
be a failure at extension link time. But yeah, most Linuxen won't
tell you till load time.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2025-01-11 00:27:12 Re: Add CASEFOLD() function.
Previous Message David Rowley 2025-01-11 00:05:07 Re: Restore support for USE_ASSERT_CHECKING in extensions only