Re: Fix a couple of typos in JIT

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Abhijit Menon-Sen <ams(at)toroid(dot)org>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Fix a couple of typos in JIT
Date: 2020-08-20 10:51:41
Message-ID: CAApHDvrFH5juxptZBVSGy1HWQOxa8_JwBq1GnDhdbavnid71Ug@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 20 Aug 2020 at 22:29, Abhijit Menon-Sen <ams(at)toroid(dot)org> wrote:
>
> At 2020-08-20 22:19:49 +1200, dgrowleyml(at)gmail(dot)com wrote:
> >
> > I was just looking over the JIT code and noticed a few comment and
> > documentation typos. The attached fixes them.
>
> The first change does not seem to be correct:
>
> -That this is done at query execution time, possibly even only in cases
> -where the relevant task is done a number of times, makes it JIT,
> -rather than ahead-of-time (AOT). Given the way JIT compilation is used
> -in PostgreSQL, the lines between interpretation, AOT and JIT are
> -somewhat blurry.
> +This is done at query execution time, possibly even only in cases where
> +the relevant task is done a number of times, makes it JIT, rather than
> +ahead-of-time (AOT). Given the way JIT compilation is used in PostgreSQL,
> +the lines between interpretation, AOT and JIT are somewhat blurry.
>
> The original sentence may not be the most shining example of
> sentence-ry, but it is correct, and removing the "That" breaks it.

Oh, I see. I missed that. Perhaps it would be better changed to "The
fact that this"

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-08-20 11:01:29 Re: New statistics for tuning WAL buffer size
Previous Message Abhijit Menon-Sen 2020-08-20 10:29:26 Re: Fix a couple of typos in JIT