Re: Fix a couple of typos in JIT

From: Abhijit Menon-Sen <ams(at)toroid(dot)org>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Fix a couple of typos in JIT
Date: 2020-08-20 10:29:26
Message-ID: 20200820102926.GA3386164@toroid.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At 2020-08-20 22:19:49 +1200, dgrowleyml(at)gmail(dot)com wrote:
>
> I was just looking over the JIT code and noticed a few comment and
> documentation typos. The attached fixes them.

The first change does not seem to be correct:

-That this is done at query execution time, possibly even only in cases
-where the relevant task is done a number of times, makes it JIT,
-rather than ahead-of-time (AOT). Given the way JIT compilation is used
-in PostgreSQL, the lines between interpretation, AOT and JIT are
-somewhat blurry.
+This is done at query execution time, possibly even only in cases where
+the relevant task is done a number of times, makes it JIT, rather than
+ahead-of-time (AOT). Given the way JIT compilation is used in PostgreSQL,
+the lines between interpretation, AOT and JIT are somewhat blurry.

The original sentence may not be the most shining example of
sentence-ry, but it is correct, and removing the "That" breaks it.

-- Abhijit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2020-08-20 10:51:41 Re: Fix a couple of typos in JIT
Previous Message David Rowley 2020-08-20 10:28:47 Re: [PG13] Planning (time + buffers) data structure in explain plan (format text)