| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, John Naylor <johncnaylorls(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add bump memory context type and use it for tuplesorts |
| Date: | 2024-04-07 23:12:10 |
| Message-ID: | CAApHDvqGiw6f=Mtt9EsnQL5_u8GxACjTNQ7YQ+cAy3JLkOTWqQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 8 Apr 2024 at 09:09, Andres Freund <andres(at)anarazel(dot)de> wrote:
> I suspect that KeeperBlock() isn't returning true, because IsKeeperBlock misses
> the MAXALIGN(). I think that about fits with:
Thanks for investigating that.
I've just pushed a fix for the macro and also adjusted a location
which was *correctly* calculating the keeper block address manually to
use the macro. If I'd used the macro there to start with the Assert
likely wouldn't have failed, but there'd have been memory alignment
issues.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2024-04-07 23:13:04 | Re: [PoC] Improve dead tuple storage for lazy vacuum |
| Previous Message | Andres Freund | 2024-04-07 23:04:56 | Re: Add bump memory context type and use it for tuplesorts |