| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru> |
| Subject: | Re: [PoC] Improve dead tuple storage for lazy vacuum |
| Date: | 2024-04-07 23:13:04 |
| Message-ID: | CANWCAZZDEjKDZbF+stUVwJ4auQf+Hhj2Skj5ty0ouUrJAQyDcw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 8, 2024 at 2:07 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Looking at the code, the failure isn't suprising anymore:
> char data[MaxBlocktableEntrySize];
> BlocktableEntry *page = (BlocktableEntry *) data;
>
> 'char' doesn't enforce any alignment, but you're storing a BlocktableEntry in
> a char[]. You can't just do that. Look at how we do that for
> e.g. PGAlignedblock.
>
>
> With the attached minimal fix, the tests pass again.
Thanks, will push this shortly!
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-04-07 23:14:23 | Re: Add bump memory context type and use it for tuplesorts |
| Previous Message | David Rowley | 2024-04-07 23:12:10 | Re: Add bump memory context type and use it for tuplesorts |