Re: Printing window function OVER clauses in EXPLAIN

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Printing window function OVER clauses in EXPLAIN
Date: 2025-03-11 01:16:07
Message-ID: CAApHDvpepuvR5jDq0rH_KzKbTA6+LuSWOgWG2thFDwvtnjyk_w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 11 Mar 2025 at 05:18, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Here's a hopefully-final v3 that makes the two changes discussed.
> Now with a draft commit message, too.

Looks good to me.

The only minor points I noted down while reviewing were 1)
name_active_windows()'s newname variable could be halved in size and,
2) explain.sql's new test could name the window "w1" instead of "w" to
exercise the name selection code a bit better. Both are minor points,
but I thought I'd mention them anyway.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2025-03-11 01:29:42 Tidy recent code bloat in pg_creatersubscriber::cleanup_objects_atexit
Previous Message Tom Lane 2025-03-11 01:13:17 Re: Memory context can be its own parent and child in replication command