| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Tidy recent code bloat in pg_creatersubscriber::cleanup_objects_atexit |
| Date: | 2025-03-11 01:29:42 |
| Message-ID: | CAHut+PtdBSVi4iH7BObDVwDNVwOpn+H3fezOBdSTtENx+rhNMw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
During a recent review of pg_creatersubscriber I saw that commit
e117cfb introduced a common 'dbinfos' struct to contain the array of
individual 'dbinfo[i]' infos. But, this now means that getting to each
dbinfo[i] requires another level of referencing.
In some places, e.g. function cleanup_objects_atexit, this caused
unnecessary code bloat. IMO this function is crying out for a local
variable to simplify the code again.
Please see the attached patch that implements this suggestion.
======
Kind Regards,
Peter Smith
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Add-cleanup_objects_atexit-local-var.patch | application/octet-stream | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2025-03-11 01:30:30 | Re: CRC32C Parallel Computation Optimization on ARM |
| Previous Message | David Rowley | 2025-03-11 01:16:07 | Re: Printing window function OVER clauses in EXPLAIN |