Re: pgsql: Server-side gzip compression.

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Server-side gzip compression.
Date: 2022-01-25 20:56:10
Message-ID: CAApHDvoKCvaK9Z0-ECZ7wjRspLyEZcv9WvOiFr1jGNLHJNuMwQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, 26 Jan 2022 at 07:12, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> wouldn't this same consideration apply to a very large number of other
> places in the code base?

All of the other places are handled. See locations with "keep compiler quiet".

This one is the only one that generates a warning:

basebackup_gzip.c(90): warning C4715: 'bbsink_gzip_new': not all
control paths return a value

David

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-01-25 23:52:52 pgsql: Revert "Temporarily add some information about python include pa
Previous Message Robert Haas 2022-01-25 20:12:33 pgsql: Tidy up a few cosmetic issues related to pg_basebackup.

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2022-01-25 21:29:55 Re: CREATEROLE and role ownership hierarchies
Previous Message Stephen Frost 2022-01-25 20:44:29 Re: CREATEROLE and role ownership hierarchies