| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Server-side gzip compression. |
| Date: | 2022-01-25 18:12:30 |
| Message-ID: | CA+TgmobSeRFM84pwa5HfZCGRx=Q-iFfPFZfq-4=t1p04yxg_Og@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Jan 25, 2022 at 4:20 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Tue, 25 Jan 2022 at 09:14, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
> > src/backend/replication/basebackup_gzip.c | 309 ++++++++++++++++++++++++++++++
>
> This could do with the attached. MSVC compilers need a bit more
> reassurance that ereport/elog ERRORs don't return.
Err, well, if we need it, we need it. It surprises me, though:
wouldn't this same consideration apply to a very large number of other
places in the code base?
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-01-25 20:12:33 | pgsql: Tidy up a few cosmetic issues related to pg_basebackup. |
| Previous Message | Tom Lane | 2022-01-25 17:18:06 | pgsql: Revert "graceful shutdown" changes for Windows, in back branches |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-01-25 18:15:43 | Re: Non-decimal integer literals |
| Previous Message | Justin Pryzby | 2022-01-25 18:07:51 | Re: GUC flags |