| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Server-side gzip compression. |
| Date: | 2022-01-27 19:43:57 |
| Message-ID: | CA+TgmoaBMWnY6yS_6WJ2Ac-CTR6uC91_wZcXUf=mGqinH2yB=g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Jan 25, 2022 at 3:56 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Wed, 26 Jan 2022 at 07:12, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > wouldn't this same consideration apply to a very large number of other
> > places in the code base?
>
> All of the other places are handled. See locations with "keep compiler quiet".
>
> This one is the only one that generates a warning:
>
> basebackup_gzip.c(90): warning C4715: 'bbsink_gzip_new': not all
> control paths return a value
OK. I'm still surprised, but it is what it is. I've committed this now.
FWIW, I would have been fine with you just committing this change. I
can't see the warning locally, so I'm not in a position to
second-guess your statement that it's needed.
Thanks,
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-01-27 20:00:52 | Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs. |
| Previous Message | Robert Haas | 2022-01-27 19:43:52 | pgsql: pg_basebackup: Add a dummy return to bbsink_gzip_new(). |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-01-27 20:18:16 | Re: Two noncritical bugs of pg_waldump |
| Previous Message | Tomas Vondra | 2022-01-27 19:33:46 | Re: Bug in ProcArrayApplyRecoveryInfo for snapshots crossing 4B, breaking replicas |