Re: BitmapHeapScan streaming read user and prelim refactoring

On Wed, Jan 22, 2025 at 4:24 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> On Mon, Dec 9, 2024 at 1:22 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > Are we planning to commit this refactoring? I think this refactoring
> > makes the overall code of BitmapHeapNext() quite clean and readable.
> > I haven't read all patches but 0001-0006 including 0009 makes this
> > code quite clean and readable. I like the refactoring of merging of
> > the shared iterator and the private iterator also.
>
> Thanks for the feedback, Dilip. I've pushed the patches through 0006.
>
> I've reorganized the remaining patches in attached v26.
>
> 0001 is just the refactoring to push the setup into a helper.
> 0002-0003 are required refactoring of the TBMIterateResult and
> TBMIterator to support the read stream API.
> 0004 implements using the read stream API and removing the old prefetching code.
> 0005 removes the table_scan_bitmap_next_block() callback, as it is not
> really used anymore in BitmapHeapNext() to get the next block.
>
> I could use review feedback on all of them. 0001 should be ready to
> push once I get some review.

Bilal mentioned offlist that 0001 had some indentation issues in one
of the comments. v27 attached.

- Melanie