| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | pg_rewind with --write-recovery-conf option doesn't write dbname to primary_conninfo value. |
| Date: | 2025-01-29 21:47:08 |
| Message-ID: | CAD21AoAkW=Ht0k9dVoBTCcqLiiZ2MXhVr+d=j2T_EZMerGrLWQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I found that pg_rewind with --write-recovery-conf option doesn't write
the dbname to an auto-generated primary_conninfo value. Therefore,
after a failover, the old primary cannot start if it's rewound by
pg_rewind with --write-recovery-conf option if sync_replication_slots
is on. Is it an oversight in commit a145f424d5? I could not see any
discussion in the thread[1] about whether we need to support adding
the dbname to the primary_conninfo value generated by pg_rewind.
I think it's a good idea to support it at least on HEAD. I've attached
a patch for that.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-pg_rewind-Add-dbname-to-primary_connifo-with-writ.patch | application/octet-stream | 7.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2025-01-29 21:55:00 | Re: Sample rate added to pg_stat_statements |
| Previous Message | Melanie Plageman | 2025-01-29 21:38:31 | Re: BitmapHeapScan streaming read user and prelim refactoring |