| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BitmapHeapScan streaming read user and prelim refactoring |
| Date: | 2025-01-30 08:02:15 |
| Message-ID: | CAN55FZ1vXu+ZdT0_MM-i1vbTdfHHf0KR3cK6R5gs6dNNNpyrJw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, 30 Jan 2025 at 00:38, Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> On Wed, Jan 22, 2025 at 4:24 PM Melanie Plageman
> <melanieplageman(at)gmail(dot)com> wrote:
> >
> > 0001 is just the refactoring to push the setup into a helper.
> > 0002-0003 are required refactoring of the TBMIterateResult and
> > TBMIterator to support the read stream API.
> > 0004 implements using the read stream API and removing the old prefetching code.
> > 0005 removes the table_scan_bitmap_next_block() callback, as it is not
> > really used anymore in BitmapHeapNext() to get the next block.
> >
> > I could use review feedback on all of them. 0001 should be ready to
> > push once I get some review.
>
> Bilal mentioned offlist that 0001 had some indentation issues in one
> of the comments. v27 attached.
I have no other comments, 0001 LGTM.
--
Regards,
Nazir Bilal Yavuz
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2025-01-30 08:34:01 | Re: why there is not VACUUM FULL CONCURRENTLY? |
| Previous Message | Matthias van de Meent | 2025-01-30 07:48:56 | RFC: Packing the buffer lookup table |