| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add tests for reinit.c |
| Date: | 2018-03-19 21:58:16 |
| Message-ID: | CAA8=A79CPVDWRgwFtowYODgu9i4p1zUsx6dpxDueRO_hxoJVJw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Mon, Mar 19, 2018 at 11:33 PM, David Steele <david(at)pgmasters(dot)net> wrote:
> On 3/19/18 4:15 AM, Andrew Dunstan wrote:
>>
>> The attached fixes it. We should probably put the function or something
>> like it in TestLib.pm, though. The call to pwd is quite tricky - it
>> needs to be done pretty much exactly like this, not quite sure why, but
>> direct calls to "pwd -W" via system() or backticks don't work, only this
>> indirect call works on jacana.
>
> Thanks for the patch, Andrew!
>
> Peter, would you like me to provide a patch that moves this function to
> TestLib.pm? Happy to do it, just don't want patches crossing in the
> night, as it were.
>
I've reworked it and pushed the fix.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-03-19 22:50:29 | pgsql: Fix some corner-case issues in REFRESH MATERIALIZED VIEW CONCURR |
| Previous Message | Andrew Dunstan | 2018-03-19 21:56:28 | pgsql: Don't use an Msys virtual path to create a tablespace |