| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add tests for reinit.c |
| Date: | 2018-03-20 02:03:48 |
| Message-ID: | 5e50bfa0-411a-2a91-2417-ab31f74cda80@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 3/19/18 5:58 PM, Andrew Dunstan wrote:
> On Mon, Mar 19, 2018 at 11:33 PM, David Steele <david(at)pgmasters(dot)net> wrote:
>> On 3/19/18 4:15 AM, Andrew Dunstan wrote:
>>>
>>> The attached fixes it. We should probably put the function or something
>>> like it in TestLib.pm, though. The call to pwd is quite tricky - it
>>> needs to be done pretty much exactly like this, not quite sure why, but
>>> direct calls to "pwd -W" via system() or backticks don't work, only this
>>> indirect call works on jacana.
>>
>> Thanks for the patch, Andrew!
>>
>> Peter, would you like me to provide a patch that moves this function to
>> TestLib.pm? Happy to do it, just don't want patches crossing in the
>> night, as it were.
>>
>
> I've reworked it and pushed the fix.
Thanks, Andrew!
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-03-20 03:59:41 | pgsql: Prevent query-lifespan memory leakage of SP-GiST traversal value |
| Previous Message | Peter Eisentraut | 2018-03-20 00:14:09 | Re: pgsql: Set libpq sslcompression to off by default |