| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add tests for reinit.c |
| Date: | 2018-03-19 13:03:50 |
| Message-ID: | 998b0442-d17c-47bf-0e92-5956d3f45448@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 3/19/18 4:15 AM, Andrew Dunstan wrote:
>
> The attached fixes it. We should probably put the function or something
> like it in TestLib.pm, though. The call to pwd is quite tricky - it
> needs to be done pretty much exactly like this, not quite sure why, but
> direct calls to "pwd -W" via system() or backticks don't work, only this
> indirect call works on jacana.
Thanks for the patch, Andrew!
Peter, would you like me to provide a patch that moves this function to
TestLib.pm? Happy to do it, just don't want patches crossing in the
night, as it were.
Thanks,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-03-19 15:55:10 | pgsql: Rewrite recurse_union_children to iterate, rather than recurse. |
| Previous Message | Magnus Hagander | 2018-03-19 09:46:16 | pgsql: Fix typo in comment |