| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Clément Prévost <prevostclement(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: parallel.c is not marked as test covered |
| Date: | 2016-06-19 06:15:21 |
| Message-ID: | CAA4eK1LEe+jJUvQa3p3LEt5eckO4Fr=YyxynaUYm-eB35T0cxQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jun 19, 2016 at 10:10 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> > With that, I think it would be preferable to undo the context-hiding
> > dance in the tests, as in the attached patch, no?
>
> Would this not result in unstable test output depending on whether the
> code executes in the leader or a worker?
>
Before doing that test, we set force_parallel_mode=1, so it should always
execute in worker which will ensure a stable output.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-06-19 08:56:12 | primary_conninfo missing from pg_stat_wal_receiver |
| Previous Message | Tom Lane | 2016-06-19 04:40:14 | Re: parallel.c is not marked as test covered |