| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: Fix comments atop ReorderBufferAddInvalidations |
| Date: | 2022-11-10 12:42:14 |
| Message-ID: | CAA4eK1L0Ndb8=jCLNk1H=SW5GDHGB97UgyxjroJNpku-AdsfHw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 4, 2022 at 11:14 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Thu, Nov 3, 2022 at 7:53 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > The comments atop seem to indicate that we always accumulate
> > invalidation messages in top-level transactions which is neither
> > required nor match with the code. This is introduced in the commit
> > c55040ccd0 and I have observed it while working on a fix for commit
> > 16b1fe0037.
>
> Thank you for the patch. It looks good to me.
>
> I think we can backpatch it to avoid confusion in future.
>
Pushed.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2022-11-10 12:46:26 | Re: Crash in BRIN minmax-multi indexes |
| Previous Message | Alvaro Herrera | 2022-11-10 12:19:51 | Re: ExecRTCheckPerms() and many prunable partitions |