Re: Fix comments atop ReorderBufferAddInvalidations

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Subject: Re: Fix comments atop ReorderBufferAddInvalidations
Date: 2022-11-04 05:43:10
Message-ID: CAD21AoDvQqKDbZ6BZuFqx4n3OuSVEEL_ZdKLEHdND9SW32qygQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

On Thu, Nov 3, 2022 at 7:53 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> The comments atop seem to indicate that we always accumulate
> invalidation messages in top-level transactions which is neither
> required nor match with the code. This is introduced in the commit
> c55040ccd0 and I have observed it while working on a fix for commit
> 16b1fe0037.

Thank you for the patch. It looks good to me.

I think we can backpatch it to avoid confusion in future.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2022-11-04 07:22:44 Re: PL/pgSQL cursors should get generated portal names by default
Previous Message Ian Lawrence Barwick 2022-11-04 05:18:17 Re: Commit fest 2022-11