Re: Remove an obsolete comment in snapbuild.c

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove an obsolete comment in snapbuild.c
Date: 2021-10-04 08:37:39
Message-ID: CAA4eK1K0Kned5xN4FEz1+PjYeFwPwhS4efxq9SU-qhj5L8=U4w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 4, 2021 at 1:24 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> Hi all,
>
> While reading the code I realized that the following comment of
> SnapBuildOnDick is obsolete:
>
> /*
> * We store current state of struct SnapBuild on disk in the following manner:
> *
> * struct SnapBuildOnDisk;
> * TransactionId * running.xcnt_space;
> * TransactionId * committed.xcnt; (*not xcnt_space*)
> *
> */
> typedef struct SnapBuildOnDisk
>
> Since SnapBuild has no longer "running" struct, it should be removed.
> Please find an attached patch.
>

LGTM. I'll push this tomorrow unless someone thinks otherwise.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2021-10-04 08:39:25 Re: replace InvalidXid(a macro that doesn't exist) with InvalidTransactionId(a macro that exists) in code comments
Previous Message Michael Paquier 2021-10-04 08:27:44 Re: Incorrect snapshots while promoting hot standby node when 2PC is used