| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Remove an obsolete comment in snapbuild.c |
| Date: | 2021-10-04 07:53:28 |
| Message-ID: | CAD21AoBifOr7RS=jRe7YCavc646y9omChv6zkWXvJeZcjS9mXA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
While reading the code I realized that the following comment of
SnapBuildOnDick is obsolete:
/*
* We store current state of struct SnapBuild on disk in the following manner:
*
* struct SnapBuildOnDisk;
* TransactionId * running.xcnt_space;
* TransactionId * committed.xcnt; (*not xcnt_space*)
*
*/
typedef struct SnapBuildOnDisk
Since SnapBuild has no longer "running" struct, it should be removed.
Please find an attached patch.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| fix_obsolete_comment_in_snapbuild.c.patch | application/octet-stream | 548 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-10-04 08:19:23 | replace InvalidXid(a macro that doesn't exist) with InvalidTransactionId(a macro that exists) in code comments |
| Previous Message | Alexander Pyhalov | 2021-10-04 07:42:56 | Re: Function scan FDW pushdown |