Re: replace InvalidXid(a macro that doesn't exist) with InvalidTransactionId(a macro that exists) in code comments

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: replace InvalidXid(a macro that doesn't exist) with InvalidTransactionId(a macro that exists) in code comments
Date: 2021-10-04 08:39:25
Message-ID: BEA11ED3-FA35-4F71-9D14-C6521F7234A0@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 4 Oct 2021, at 10:19, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:

> It seems like we have macro InvalidTransactionId but InvalidXid is
> used in some of the code comments.Here's a small patch that does
> $subject?

While I doubt anyone would be confused by these, I do agree it's worth being
consistent and use the right terms. Pushed to master, thanks!

--
Daniel Gustafsson https://vmware.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Lakhin 2021-10-04 09:00:01 Re: BUG #17212: pg_amcheck fails on checking temporary relations
Previous Message Amit Kapila 2021-10-04 08:37:39 Re: Remove an obsolete comment in snapbuild.c