Re: Ignore heap rewrites for materialized views in logical replication

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Euler Taveira <euler(at)eulerto(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Ignore heap rewrites for materialized views in logical replication
Date: 2022-05-31 14:13:50
Message-ID: CAA4eK1Jp0hXtugP6DhwtE7n84_ufUQuNR3bQqnkXkMVMwRah4Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 31, 2022 at 6:27 AM Euler Taveira <euler(at)eulerto(dot)com> wrote:
>
> On Sat, May 28, 2022, at 7:07 AM, Amit Kapila wrote:
>
> I agree with your analysis and the fix looks correct to me.
>
> Thanks for checking.
>
> Instead of waiting for an error, we can try to insert into a new table
> created by the test case after the 'Refresh ..' command and wait for
> the change to be replicated by using wait_for_caught_up.
>
> That's a good idea. [modifying the test...] I used the same table. Whenever the
> new row arrives on the subscriber or it reads that error message, it bails out.
>

I think we don't need the retry logical to check error, a simple
wait_for_caught_up should be sufficient as we are doing in other
tests. See attached. I have slightly modified the commit message as
well. Kindly let me know what you think?

--
With Regards,
Amit Kapila.

Attachment Content-Type Size
v3-0001-Ignore-heap-rewrites-for-materialized-views-in-lo.patch application/octet-stream 3.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-05-31 14:16:45 Re: PostgreSQL Limits: maximum number of columns in SELECT result
Previous Message Dave Cramer 2022-05-31 14:10:13 Re: PostgreSQL Limits: maximum number of columns in SELECT result