Re: Ignore heap rewrites for materialized views in logical replication

From: "Euler Taveira" <euler(at)eulerto(dot)com>
To: "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>
Cc: "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Ignore heap rewrites for materialized views in logical replication
Date: 2022-05-31 14:57:43
Message-ID: 572b47ac-a0b0-41de-b2f5-2b29c71e64da@www.fastmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 31, 2022, at 11:13 AM, Amit Kapila wrote:
> I think we don't need the retry logical to check error, a simple
> wait_for_caught_up should be sufficient as we are doing in other
> tests. See attached. I have slightly modified the commit message as
> well. Kindly let me know what you think?
Your modification will hang until the test timeout without the patch. That's
why I avoided to use wait_for_caught_up and used a loop for fast exit on success
or failure. I'm fine with a simple test case like you proposed.

--
Euler Taveira
EDB https://www.enterprisedb.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-05-31 15:09:11 Re: PG15 beta1 sort performance regression due to Generation context change
Previous Message Robert Haas 2022-05-31 14:51:25 Re: PG15 beta1 sort performance regression due to Generation context change