| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Ignore heap rewrites for materialized views in logical replication |
| Date: | 2022-05-31 00:56:26 |
| Message-ID: | 3dbf4521-1a8c-419d-8447-86dc1689d3f7@www.fastmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 28, 2022, at 7:07 AM, Amit Kapila wrote:
> I agree with your analysis and the fix looks correct to me.
Thanks for checking.
> Instead of waiting for an error, we can try to insert into a new table
> created by the test case after the 'Refresh ..' command and wait for
> the change to be replicated by using wait_for_caught_up.
That's a good idea. [modifying the test...] I used the same table. Whenever the
new row arrives on the subscriber or it reads that error message, it bails out.
> Let's try to see if we can simplify the test so that it can be
> committed along with a fix. If we are not able to find any reasonable
> way then we can think of skipping it.
The new test is attached.
--
Euler Taveira
EDB https://www.enterprisedb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Ignore-heap-rewrites-for-materialized-views-in-lo.patch | text/x-patch | 1.6 KB |
| v2-0002-test-heap-rewrite-for-materialized-view-in-logica.patch | text/x-patch | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-05-31 01:31:07 | Re: Race conditions in 019_replslot_limit.pl |
| Previous Message | Michael Paquier | 2022-05-31 00:49:40 | Re: Remove useless tests about TRUNCATE on foreign table |