| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: extra semicolon in postgres_fdw test cases |
| Date: | 2021-03-30 11:30:53 |
| Message-ID: | CAA4eK1JnLiewCmnyiqqrBBy-5s932b=1zRQZ_UFMT+ynuN7KPw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 30, 2021 at 4:50 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Tue, Mar 30, 2021 at 3:21 PM Suraj Kharage
> <suraj(dot)kharage(at)enterprisedb(dot)com> wrote:
> >
> > Hi,
> >
> > Noticed that an extra semicolon in a couple of test cases related to postgres_fdw. Removed that in the attached patch. It can be backported till v11 where we added those test cases.
>
> +1 for the change. It looks like a typo and can be backported.
>
Looks good to me as well but I think one can choose not to backpatch
as there is no functional impact but OTOH, there is some value in
keeping tests/code consistent.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Markus Wanner | 2021-03-30 11:31:36 | Re: [PATCH] add concurrent_abort callback for output plugin |
| Previous Message | Markus Wanner | 2021-03-30 11:29:43 | Re: [PATCH] add concurrent_abort callback for output plugin |