Re: [PATCH] add concurrent_abort callback for output plugin

From: Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Ajin Cherian <itsajin(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] add concurrent_abort callback for output plugin
Date: 2021-03-30 11:31:36
Message-ID: 221f1930-0ea6-6c72-03c4-5261a2ce2010@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 30.03.21 11:54, Markus Wanner wrote:
> I would recommend this more explicit API and communication over hiding
> the concurrent abort in a prepare callback.

I figured we already have the ReorderBufferTXN's concurrent_abort flag,
thus I agree the prepare_cb is sufficient and revoke this recommendation
(and the concurrent_abort callback patch).

Regards

Markus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiro Ikeda 2021-03-30 11:37:36 Re: wal stats questions
Previous Message Amit Kapila 2021-03-30 11:30:53 Re: extra semicolon in postgres_fdw test cases