Re: Invalid Assert while validating REPLICA IDENTITY?

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Invalid Assert while validating REPLICA IDENTITY?
Date: 2024-09-02 10:02:24
Message-ID: CAA4eK1JHTzrnnKE4sKE5m_iFkyd0tGDRA=gLbXOXJ6q2ZKYjNQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 2, 2024 at 11:21 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> While working on some other code I noticed that in
> FindReplTupleInLocalRel() there is an assert [1] that seems to be
> passing IndexRelation to GetRelationIdentityOrPK() whereas it should
> be passing normal relation.
>

Agreed. But this should lead to assertion failure. Did you try testing it?

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2024-09-02 10:03:07 Re: AIO v2.0
Previous Message Amit Kapila 2024-09-02 09:50:06 Re: Introduce XID age and inactive timeout based replication slot invalidation