| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <akapila(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Allow multiple xacts during table sync in logical replication. |
| Date: | 2021-02-13 05:26:06 |
| Message-ID: | CAA4eK1J3cDHV9ioavb=mxvKq1hh9dAzuiVoucnEkj6JF4h3wsw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sat, Feb 13, 2021 at 9:49 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> > Attached should fix the reported warnings but as I am not getting
> > those warnings on my system so can't confirm but otherwise, the patch
> > works as expected. I am planning to push this unless you or Peter have
> > any comments.
>
> Personally I'd get rid of the option for ReplicationSlotNameForTablesync
> to allocate the result buffer.
>
Sounds reasonable and the updated patch attached.
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| fix_warnings_tblsync_2.patch | application/octet-stream | 7.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-02-13 07:07:02 | pgsql: doc: Mention NO DEPENDS ON EXTENSION in its supported ALTER comm |
| Previous Message | Tom Lane | 2021-02-13 04:19:15 | Re: pgsql: Allow multiple xacts during table sync in logical replication. |