| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <akapila(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Allow multiple xacts during table sync in logical replication. |
| Date: | 2021-02-13 04:19:15 |
| Message-ID: | 1625664.1613189955@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> Attached should fix the reported warnings but as I am not getting
> those warnings on my system so can't confirm but otherwise, the patch
> works as expected. I am planning to push this unless you or Peter have
> any comments.
Personally I'd get rid of the option for ReplicationSlotNameForTablesync
to allocate the result buffer. There's only one caller using that,
so it's saving no code to have ReplicationSlotNameForTablesync do the
alloc rather than that one caller; and it seems mighty ugly/nonorthogonal
to have effectively two different APIs in one function.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-02-13 05:26:06 | Re: pgsql: Allow multiple xacts during table sync in logical replication. |
| Previous Message | Amit Kapila | 2021-02-13 04:01:37 | Re: pgsql: Allow multiple xacts during table sync in logical replication. |