| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <akapila(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Allow multiple xacts during table sync in logical replication. |
| Date: | 2021-02-15 10:35:59 |
| Message-ID: | CAA4eK1LkG8fQ+Bd8DbGLjNOtX_mteTGqPF2vo-YRS4KVZsnh0w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sat, Feb 13, 2021 at 10:56 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Sat, Feb 13, 2021 at 9:49 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> > Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> > > Attached should fix the reported warnings but as I am not getting
> > > those warnings on my system so can't confirm but otherwise, the patch
> > > works as expected. I am planning to push this unless you or Peter have
> > > any comments.
> >
> > Personally I'd get rid of the option for ReplicationSlotNameForTablesync
> > to allocate the result buffer.
> >
>
> Sounds reasonable and the updated patch attached.
>
Pushed and I don't see those warnings on caiman.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-02-15 15:18:13 | pgsql: Simplify loop logic in nodeIncrementalSort.c. |
| Previous Message | Heikki Linnakangas | 2021-02-15 07:31:46 | pgsql: Make ExecGetInsertedCols() and friends more robust and improve c |