Re: PATCH: Clear undo/redo history when a file is opened in Query editor

Hi J.F.

Thank you for the clarification.
I have reviewed the patch.
It seems working fine.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Tue, Oct 28, 2014 at 9:38 PM, J.F. Oster <jinfroster(at)mail(dot)ru> wrote:

> Hello Sanket,
>
>
> SM> As per my understanding below is the bug scenario.
> Yes,
>
> - open any file in sql editor..
> - perform some modifications to file so that Undo is possible.
> - now open a second file in same editor and try Undo. It will show
> you previous file content again.═
> - do Save.
>
> Now contents of the second file is replaced on disk with contents of
> the previous file.
>
>
> SM> On Mon, Oct 27, 2014 at 4:14 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> SM> Ashesh, can you review/commit this please?
>
> SM> On Fri, Oct 24, 2014 at 8:35 PM, J.F. Oster <jinfroster(at)mail(dot)ru>
> wrote:
> >> Hello!
> >>
> >> A user may occasionaly assign content of a previously edited file into
> >> a next file opened in the same Query window, by calling Undo and Save.
> >>
> >> Simple non-MDI text editors (for example, notepad.exe) prevent an
> >> issue by clearing undo/redo history, so should we do.
> >> Please see the attached patch.
> >>
>
>
> --
> Best regards,
> J.F.
>
>