From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | "J(dot)F(dot) Oster" <jinfroster(at)mail(dot)ru>, Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com> |
Cc: | Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: Clear undo/redo history when a file is opened in Query editor |
Date: | 2014-10-30 05:38:57 |
Message-ID: | CAG7mmozDbZsJMya=8p=XMODdDjzgYH9d5ob2-ok91qYdzRufCA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks for the patch.
Committed to the master branch.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
On Tue, Oct 28, 2014 at 9:59 PM, Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com
> wrote:
> Hi J.F.
>
> Thank you for the clarification.
> I have reviewed the patch.
> It seems working fine.
>
>
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Tue, Oct 28, 2014 at 9:38 PM, J.F. Oster <jinfroster(at)mail(dot)ru> wrote:
>
>> Hello Sanket,
>>
>>
>> SM> As per my understanding below is the bug scenario.
>> Yes,
>>
>> - open any file in sql editor..
>> - perform some modifications to file so that Undo is possible.
>> - now open a second file in same editor and try Undo. It will show
>> you previous file content again.═
>> - do Save.
>>
>> Now contents of the second file is replaced on disk with contents of
>> the previous file.
>>
>>
>> SM> On Mon, Oct 27, 2014 at 4:14 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> SM> Ashesh, can you review/commit this please?
>>
>> SM> On Fri, Oct 24, 2014 at 8:35 PM, J.F. Oster <jinfroster(at)mail(dot)ru>
>> wrote:
>> >> Hello!
>> >>
>> >> A user may occasionaly assign content of a previously edited file into
>> >> a next file opened in the same Query window, by calling Undo and Save.
>> >>
>> >> Simple non-MDI text editors (for example, notepad.exe) prevent an
>> >> issue by clearing undo/redo history, so should we do.
>> >> Please see the attached patch.
>> >>
>>
>>
>> --
>> Best regards,
>> J.F.
>>
>>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2014-10-30 05:41:00 | Re: PATCH: Fix Explain data output column not auto-sizing |
Previous Message | Ashesh Vashi | 2014-10-30 05:33:31 | Re: PATCH: Support smallserial columns in Edit Data window |