| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Assert in heapgettup_pagemode() fails due to underlying buffer change |
| Date: | 2024-06-08 22:01:08 |
| Message-ID: | CA+hUKGKXCF1PH16Kusnah39wcK-2PxR71dAZ7L+gNcU=UPfi7Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 7, 2024 at 8:05 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> In passing, I noticed that WaitReadBuffers has zero comments, which
> seems an insufficient number of them.
Ack. Here is a patch for that. I guess I hadn't put a comment there
because it's hard to write anything without sort of duplicating what
is already said by the StartReadBuffers() comment and doubling down on
descriptions of future plans... but, in for a penny, in for a pound as
they say.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-comment-for-WaitReadBuffers.patch | application/x-patch | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aaron Altman | 2024-06-08 22:04:44 | Re: Fix grammar oddities in comments |
| Previous Message | Thomas Munro | 2024-06-08 21:42:44 | Re: Assert in heapgettup_pagemode() fails due to underlying buffer change |