| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Assert in heapgettup_pagemode() fails due to underlying buffer change |
| Date: | 2024-06-10 02:30:16 |
| Message-ID: | CA+hUKGKBuYg8iH6U4VP8vD_9fCEVhxPdqjt6Vp5_sNeBB9YrgQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I adjusted the code a bit more to look like the 16 coding including
restoring some very useful comments that had been lost, and pushed.
Thanks very much to Alexander and Noah for (independently) chasing
this down and reporting, testing etc, and Alvaro and Robert for review
comments.
(Passing thought: it's a bit weird that we need to zero pages at all
before restoring FPIs or initialising them. Perhaps there is some way
to defer marking the buffer valid until after the caller gets a chance
to initialise? Or something like that...)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-06-10 02:37:03 | Re: Remove dependence on integer wrapping |
| Previous Message | Tom Lane | 2024-06-10 02:12:53 | Re: CheckMyDatabase some error messages in two lines. |