Re: Assert in heapgettup_pagemode() fails due to underlying buffer change

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Alexander Lakhin <exclusion(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Assert in heapgettup_pagemode() fails due to underlying buffer change
Date: 2024-06-07 08:05:43
Message-ID: 202406070805.icofqromovvn@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2024-Jun-07, Thomas Munro wrote:

> static void
> -ZeroBuffer(Buffer buffer, ReadBufferMode mode)
> +ZeroBuffer(Buffer buffer, ReadBufferMode mode, bool zero)

This change makes the API very strange. Should the function be called
ZeroAndLockBuffer() instead? Then the addition of a "bool zero"
argument makes a lot more sense.

In passing, I noticed that WaitReadBuffers has zero comments, which
seems an insufficient number of them.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ryo Matsumura (Fujitsu) 2024-06-07 08:09:03 Re: Bug: PGTYPEStimestamp_from_asc() in ECPG pgtypelib
Previous Message Peter Eisentraut 2024-06-07 07:44:26 Re: meson: Specify -Wformat as a common warning flag for extensions