Re: check_strxfrm_bug()

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: check_strxfrm_bug()
Date: 2023-07-03 01:49:02
Message-ID: CA+hUKGKWH6f6fAKzbcb9KfMYPEVUaCNvWOcabdoCZSaA0_Z7ww@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jul 2, 2023 at 4:25 AM Noah Misch <noah(at)leadboat(dot)com> wrote:
> On Wed, Jun 28, 2023 at 01:02:21PM +1200, Thomas Munro wrote:
> > On Wed, Jun 28, 2023 at 11:03 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > > The GCC build farm has just received some SPARC hardware new enough to
> > > run modern Solaris (hostname gcc106), so if wrasse were moved over
> > > there we could finally assume all systems have POSIX 2008 (AKA
> > > SUSv4)'s locale_t.
> >
> > That would look something like this.
>
> This removes thirty-eight ifdefs, most of them located in the middle of
> function bodies. That's far more beneficial than most proposals to raise
> minimum requirements. +1 for revoking support for wrasse's OS version.
> (wrasse wouldn't move, but it would stop testing v17+.)

Great. It sounds like I should wait a few days for any other feedback
and then push this patch. Thanks for looking.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2023-07-03 01:50:45 Re: ProcessStartupPacket(): database_name and user_name truncation
Previous Message Masahiko Sawada 2023-07-03 01:45:52 Re: Skip collecting decoded changes of already-aborted transactions