Re: check_strxfrm_bug()

From: "Tristan Partin" <tristan(at)neon(dot)tech>
To: "Thomas Munro" <thomas(dot)munro(at)gmail(dot)com>, "Noah Misch" <noah(at)leadboat(dot)com>
Cc: "Heikki Linnakangas" <hlinnaka(at)iki(dot)fi>, "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: check_strxfrm_bug()
Date: 2023-07-03 14:52:23
Message-ID: CTSMESM194SC.V0R8IMBEYEOZ@gonk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun Jul 2, 2023 at 8:49 PM CDT, Thomas Munro wrote:
> On Sun, Jul 2, 2023 at 4:25 AM Noah Misch <noah(at)leadboat(dot)com> wrote:
> > On Wed, Jun 28, 2023 at 01:02:21PM +1200, Thomas Munro wrote:
> > > On Wed, Jun 28, 2023 at 11:03 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > > > The GCC build farm has just received some SPARC hardware new enough to
> > > > run modern Solaris (hostname gcc106), so if wrasse were moved over
> > > > there we could finally assume all systems have POSIX 2008 (AKA
> > > > SUSv4)'s locale_t.
> > >
> > > That would look something like this.
> >
> > This removes thirty-eight ifdefs, most of them located in the middle of
> > function bodies. That's far more beneficial than most proposals to raise
> > minimum requirements. +1 for revoking support for wrasse's OS version.
> > (wrasse wouldn't move, but it would stop testing v17+.)
>
> Great. It sounds like I should wait a few days for any other feedback
> and then push this patch. Thanks for looking.

The patch looks good to me as well. Happy to rebase my other patch on
this one.

--
Tristan Partin
Neon (https://neon.tech)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2023-07-03 15:18:25 Re: pg_basebackup check vs Windows file path limits
Previous Message Tristan Partin 2023-07-03 14:49:21 Re: Make uselocale protection more consistent