Re: Why is citext/regress failing on hamerkop?

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: "David E(dot) Wheeler" <david(at)justatheory(dot)com>
Cc: Oleg Tselebrovskiy <o(dot)tselebrovskiy(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Why is citext/regress failing on hamerkop?
Date: 2024-08-02 22:02:48
Message-ID: CA+hUKG+8-U6ndSjbF9=2uuMwMtq2nBuBETge4dCnG-QqspVJAg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Aug 3, 2024 at 2:11 AM David E. Wheeler <david(at)justatheory(dot)com> wrote:
> Haven’t been following this thread, but this post reminded me of an issue I saw with locales on Windows[1]. Could it be that the introduction of Universal CRT[2] in Windows 10 has improved UTF-8 support?

Yeah. We have a few places that claim that Windows APIs can't do
UTF-8 and they have to do extra wchar_t conversions, but that doesn't
seem to be true on modern Windows. Example:

https://github.com/postgres/postgres/blob/7926a9a80f6daf0fcc1feb1bee5c51fd001bc173/src/backend/utils/adt/pg_locale.c#L1814

I suspect that at least when the locale name is "en-US.UTF-8", then
the regular POSIXoid strcoll_l() function should just work™ and we
could delete all that stuff and save Windows users a lot of wasted CPU
cycles.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Hale Boyes 2024-08-03 00:44:58 Re: [HACKERS] make async slave to wait for lsn to be replayed
Previous Message Tom Lane 2024-08-02 20:26:08 Draft release notes for next week's releases are up