| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ALTER TABLE lock strength reduction patch is unsafe |
| Date: | 2014-01-24 08:33:32 |
| Message-ID: | CA+U5nMKU1WhHUBSwNDK1suC+jnXXSEqN_REanjPhpVvBKDViUg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 24 January 2014 07:08, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Wed, Jan 15, 2014 at 6:57 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> v15 to fix the above problem.
>
> Minor quibble: I get a compiler warning with the patch applied.
> "relcache.c: In function 'RememberToFreeTupleDescAtEOX':
> relcache.c:2317:3: warning: ISO C90 forbids mixed declarations and
> code [-Werror=declaration-after-statement]".
Thanks, that was a wart, now fixed.
v16 attached
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| reduce_lock_levels.v16.patch | application/octet-stream | 25.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2014-01-24 08:50:48 | Re: GIN improvements part 1: additional information |
| Previous Message | Alexander Korotkov | 2014-01-24 08:03:04 | Re: GIN improvements part 1: additional information |