| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tv(at)fuzzy(dot)cz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GIN improvements part 1: additional information |
| Date: | 2014-01-24 08:50:48 |
| Message-ID: | 52E22968.2050100@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/24/2014 10:03 AM, Alexander Korotkov wrote:
> ITSM I found this bug. ginVacuumPostingTreeLeaf re-encodes only some
> segments. Others are not even re-palloced. They are moved left
> in dataPlaceToPageLeafRecompress by memcpy. But it's incorrect to with
> memcpy, proper solution is memmove. Using memcpy platform dependently can
> lead to page corruption. Another solution is to re-palloc segments in
> ginVacuumPostingTreeLeaf.
Good catch. Thanks, committed, changing memcpy to memmove. Will have to
switch to pallocing everything in the future, if we make leafRepackItems
smarter, so that it doesn't rewrite all the segments after the first
modified one.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2014-01-24 08:53:26 | Re: GIN improvements part 1: additional information |
| Previous Message | Simon Riggs | 2014-01-24 08:33:32 | Re: ALTER TABLE lock strength reduction patch is unsafe |