Re: parallel explain analyze support not exercised

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: parallel explain analyze support not exercised
Date: 2017-04-03 21:11:33
Message-ID: CA+Tgmobb=7WvzTTOfiC23dYydjywB9=pp5HUXC1xSfQm1wOcDw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 3, 2017 at 3:31 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> If this is 'make check', then we should have 8 parallel workers
>> allowed, so if we only do one of these at a time, then I think we're
>> OK. But if somebody changes that configuration setting or if it's
>> 'make installcheck', then the configuration could be anything.
>
> Hm - we already rely on max_parallel_workers_per_gather being set with
> some of the explains in the test. So I guess we're ok also relying on
> actual workers being present?

I'm not really sure about that one way or the other. Our policy on
which configurations are supported vis-a-vis 'make installcheck' seems
to be, essentially, that if a sufficiently-prominent community member
cares about it, then it ends up getting made to work, unless an
even-more-prominent community member objects. That's why, for
example, our regression tests pass in Czech. I can't begin to guess
whether breaking installcheck against configurations with low values
of max_parallel_workers or max_worker_processes will bother anybody.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-04-03 21:11:46 Re: WIP: [[Parallel] Shared] Hash
Previous Message Andres Freund 2017-04-03 21:09:04 Re: [PATCH] Incremental sort