Re: parallel explain analyze support not exercised

From: Andres Freund <andres(at)anarazel(dot)de>
To: Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: parallel explain analyze support not exercised
Date: 2017-04-06 20:50:19
Message-ID: 20170406205019.yi4avldebc3ca4df@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2017-04-03 17:11:33 -0400, Robert Haas wrote:
> On Mon, Apr 3, 2017 at 3:31 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> >> If this is 'make check', then we should have 8 parallel workers
> >> allowed, so if we only do one of these at a time, then I think we're
> >> OK. But if somebody changes that configuration setting or if it's
> >> 'make installcheck', then the configuration could be anything.
> >
> > Hm - we already rely on max_parallel_workers_per_gather being set with
> > some of the explains in the test. So I guess we're ok also relying on
> > actual workers being present?
>
> I'm not really sure about that one way or the other. Our policy on
> which configurations are supported vis-a-vis 'make installcheck' seems
> to be, essentially, that if a sufficiently-prominent community member
> cares about it, then it ends up getting made to work, unless an
> even-more-prominent community member objects. That's why, for
> example, our regression tests pass in Czech. I can't begin to guess
> whether breaking installcheck against configurations with low values
> of max_parallel_workers or max_worker_processes will bother anybody.

I guess we'll have to see. My personal conclusion is that greater
coverage of parallelism is worth some very minor config trouble for
people doing installcheck against clusters with non-default config.

Thanks Rafia!

- Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yorick Peterse 2017-04-06 21:00:34 [PATCH] Document the order of changing certain settings when using hot-standby servers
Previous Message Andres Freund 2017-04-06 20:43:55 Re: parallel bitmapscan isn't exercised in regression tests