Re: A slightly misleading comment in GetNewObjectId()

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A slightly misleading comment in GetNewObjectId()
Date: 2018-08-16 15:36:58
Message-ID: CA+Tgmoa45LXZMbP_oO35FVgj=sGDkDM7zxc078go2A+brf=wcA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 16, 2018 at 12:47 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
>> That makes it sound like a mere optimisation, but since commit
>> 8e18d04d4da user-created objects are not allowed to have OIDs below
>> that threshold. So I propose the attached tweak.
>
> +1

Looks good to me, too.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-08-16 15:39:26 Re: Memory leak with CALL to Procedure with COMMIT.
Previous Message Justin Clift 2018-08-16 15:32:00 Re: Problem with OpenSCG downloads