Re: FW: REVIEW: Allow formatting in log_line_prefix

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: FW: REVIEW: Allow formatting in log_line_prefix
Date: 2013-09-26 21:18:43
Message-ID: CA+TgmoZycK-ko7_FqYU+z7Ysj=9j9LvzxLK5D+yvqg0tnkzErg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 26, 2013 at 3:55 PM, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I think I must have forgot to save it before I emailed it...
>
> Here's the correct version.

Ah ha. Looks better.

I'm working on getting this committed now. Aside from some stylistic
things, I've found one serious functional bug, which is that you need
to test padding != 0, not padding > 0, when deciding which path to
take. No need to send a new patch, I've already fixed it in my local
copy...

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2013-09-26 21:50:08 Re: record identical operator - Review
Previous Message Bruce Momjian 2013-09-26 20:52:19 Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE