| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: FW: REVIEW: Allow formatting in log_line_prefix |
| Date: | 2013-09-26 22:28:09 |
| Message-ID: | CA+TgmoZ5vybFuR_tvs4fbGMOPC+E9CAT0ivXTzr8xNWRp9esFA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 26, 2013 at 5:18 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Sep 26, 2013 at 3:55 PM, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>> I think I must have forgot to save it before I emailed it...
>>
>> Here's the correct version.
>
> Ah ha. Looks better.
>
> I'm working on getting this committed now. Aside from some stylistic
> things, I've found one serious functional bug, which is that you need
> to test padding != 0, not padding > 0, when deciding which path to
> take. No need to send a new patch, I've already fixed it in my local
> copy...
Committed now. Let me know if I broke anything.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2013-09-26 22:55:45 | Wait free LW_SHARED acquisition |
| Previous Message | Bruce Momjian | 2013-09-26 21:56:38 | Re: [PATCH] pg_upgrade: Split off pg_fatal() from pg_log() |