Re: FW: REVIEW: Allow formatting in log_line_prefix

On Fri, Sep 27, 2013 at 10:28 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Thu, Sep 26, 2013 at 5:18 PM, Robert Haas <robertmhaas(at)gmail(dot)com>
> wrote:
> > On Thu, Sep 26, 2013 at 3:55 PM, David Rowley <dgrowleyml(at)gmail(dot)com>
> wrote:
> >> I think I must have forgot to save it before I emailed it...
> >>
> >> Here's the correct version.
> >
> > Ah ha. Looks better.
> >
> > I'm working on getting this committed now. Aside from some stylistic
> > things, I've found one serious functional bug, which is that you need
> > to test padding != 0, not padding > 0, when deciding which path to
> > take. No need to send a new patch, I've already fixed it in my local
> > copy...
>
>
Oops, negative padding. My bad. I was focusing too much on the benchmarks I
think.

> Committed now. Let me know if I broke anything.
>
>
Great, thanks for commiting!
Thank you Albe for your review too!

Regards

David.

> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>