| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com> |
| Subject: | Re: refactoring basebackup.c |
| Date: | 2021-09-21 16:51:55 |
| Message-ID: | CA+TgmoZ1XNbkUPUOnASR-Kfu-ypqj+GXX4E0WRQc+-2ps-cPVQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 21, 2021 at 7:54 AM Jeevan Ladhe
<jeevan(dot)ladhe(at)enterprisedb(dot)com> wrote:
> I was wondering if we should change the bbs_buffer_length in bbsink to
> be size_t instead of int, because that's what most of the compression
> libraries have their length variables defined as.
I looked into this and found that I was already using size_t or Size
in a bunch of related places, so this seems to make sense.
Here's a new patch set, responding also to Sergei's comments.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0006-Modify-pg_basebackup-to-use-a-new-COPY-subprotoco.patch | application/octet-stream | 33.8 KB |
| v6-0007-Support-base-backup-targets.patch | application/octet-stream | 32.1 KB |
| v6-0001-Flexible-options-for-BASE_BACKUP.patch | application/octet-stream | 25.3 KB |
| v6-0008-WIP-Server-side-gzip-compression.patch | application/octet-stream | 17.7 KB |
| v6-0005-Introduce-bbstreamer-abstraction-to-modularize-pg.patch | application/octet-stream | 80.3 KB |
| v6-0003-Refactor-basebackup.c-s-_tarWriteDir-function.patch | application/octet-stream | 4.0 KB |
| v6-0002-Flexible-options-for-CREATE_REPLICATION_SLOT.patch | application/octet-stream | 16.4 KB |
| v6-0004-Introduce-bbsink-abstraction-to-modularize-base-b.patch | application/octet-stream | 76.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-09-21 16:56:56 | Re: refactoring basebackup.c |
| Previous Message | Robert Haas | 2021-09-21 16:27:21 | Re: extensible options syntax for replication parser? |